You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This depends on pyiron_base 1356, and turns off the automatic name mangling for NodeJob. There is certainly not a large corpus of workflow jobs depending on the old naming scheme, so this can be a patch.
@jan-janssen@srmnitc, I don't know what the timetable is for the DPG or whether base releases can get made sufficiently quickly to utilize this, but it is far and away preferable to #225, which is wrongly patching a problem in _base but only inside _workflow.
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%
This won't be necessary, the next version of base will jump straight to pyrion_base 1358, so we'll get the desired renaming behaviour by default and never need to exploit the mangling flag
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on
pyiron_base1356, and turns off the automatic name mangling forNodeJob. There is certainly not a large corpus of workflow jobs depending on the old naming scheme, so this can be a patch.@jan-janssen @srmnitc, I don't know what the timetable is for the DPG or whether base releases can get made sufficiently quickly to utilize this, but it is far and away preferable to #225, which is wrongly patching a problem in
_basebut only inside_workflow.